Create Label class and implement methods #33
Conversation
There was a problem hiding this comment.
Status: Approved 🟢 🥇 💯
Hey @AndreaM2429 👋
Great work on implementing the Book Class and its metohds. Your task are complete. 😊
There is nothing else to say about your project: lets merge it 👍
Highlights 🥇
✔️ Descriptive Pull Request Title & info
✔️ Linters running
✔️ Label class in another file and all properties defined
✔️ can_be_archived?() Method correctly implemented
✔️ App Class functionalities correctly working: create_book; list_all_books
✔️ Add item method currently working
Optional
All the changes with optional tags are not crucial enough to prevent you from getting the approval but we highly recommend to students that they should take these changes into consideration.
Happy coding! 👏 👏 👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hello there, I implemented new features to resolve the list requirements, and I'd like to merge them into the
developbranch. Thanks in advance for taking the time to review my code.Milestones:
Labelclass with an association to the Item class in a separate .rb file.Labelclass properties visible in the diagram are defined and set up in the constructor method.add_itemthat takes an instance of the Item class as an input, adds the input item to the collection of items and adds self as a property of the item objectAppclass: